search

frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
109 stars 23 forks source link

Error with MRP in latest relese #173

Closed WanderingFox closed 1 year ago

WanderingFox commented 1 year ago

Describe the bug After updating tiptac to 23.01.23 an error is generated when trying to call msp:Request(name, field); on line 2071 in ttCore.lua.

It is passing a name parameter that appears to be undefined.

36x MyRolePlay/Libs/LibMSP/LibMSP.lua:750: Chomp.NameMergedRealm: name: expected string, got nil
[string "=[C]"]: in function `error'
[string "@MyRolePlay/Libs/LibMSP/Libs/Chomp/StringManip.lua"]:104: in function `NameMergedRealm'
[string "@MyRolePlay/Libs/LibMSP/LibMSP.lua"]:750: in function `Request'
[string "@TipTac/ttCore.lua"]:2171: in function `SetUnitRecordFromTip'
[string "@TipTac/ttCore.lua"]:2327: in function `?'
[string "@TipTac/libs/LibFroznFunctions-1.0-2/LibFroznFunctions-1.0.lua"]:688: in function `FireGroupEvent'
[string "@TipTac/ttCore.lua"]:1174: in function `SetCurrentDisplayParams'
[string "@TipTac/ttCore.lua"]:1086: in function <TipTac/ttCore.lua:1085>
[string "@TipTac/libs/LibFroznFunctions-1.0-2/LibFroznFunctions-1.0.lua"]:137: in function <...libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua:135>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `securecallfunction'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:60: in function <SharedXML/Tooltip/TooltipDataHandler.lua:55>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:80: in function <SharedXML/Tooltip/TooltipDataHandler.lua:76>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:116: in function <SharedXML/Tooltip/TooltipDataHandler.lua:106>
[string "=[C]"]: in function `SetAttribute'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:141: in function <SharedXML/Tooltip/TooltipDataHandler.lua:134>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:282: in function <SharedXML/Tooltip/TooltipDataHandler.lua:240>
[string "=[C]"]: in function `securecallfunction'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:237: in function <SharedXML/Tooltip/TooltipDataHandler.lua:236>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `SetUnit'
[string "@PitBull4/UnitFrame.lua"]:256: in function <PitBull4/UnitFrame.lua:251>

Locals:
(*temporary) = "Chomp.NameMergedRealm: name: expected string, got nil"

To Reproduce Steps to reproduce the behavior: Mouse over a player so that the tooltip is shown

Expected behavior No error message should be generated

Screenshots N/A

TipTac Reborn (please complete the following information):

WoW (please complete the following information):

Additional context A quick glance suggests that name is just missing. Its first reference in tt:SetUnitRecordFromTip is in the offending line.

frozn commented 1 year ago

Thanks for reporting this! 👍

I overlocked that, because I don't use LibMSP. :see_no_evil:

Fix will be included with the next release. Because the core files has been completely rewritten with the latest release, I will wait a little longer to see if more errors are reported.

In the meantime, you could use this dev version: TipTac-dev.zip