frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
109 stars 23 forks source link

Many broken things with 23.01.23 #175

Closed tflo closed 1 year ago

tflo commented 1 year ago

23.01.23 seems badly broken:

This is just what I observed immediatly after updating TipTac (had to roll back to previous version), probably there are more glitches and interferences. Deactivating TipTac removes all symptoms described above. No errors logged in BugSack.

Let me know if you need more info, or screenshots.

Edit/PS: This is on Retail 100002.

hollo6 commented 1 year ago

SavedInstances close button also disappears, already on first use. Edit: not missing, just somewhere in the middle of the frame (I guess that's where it should be, but the frame itself gets moved and resized).

frozn commented 1 year ago

I fixed many things with the latest release v23.01.28.

Regarding addon SavedInstances: Some addons doesn't handle scaling properly. For LibDropdown-1.0 and LibDropdownMC-1.0 I opened a pull request on their GitHub page. Additionally I added the styling of these tooltips in TipTac which also handles the scaling itself in the latest release.

I installed SavedInstances for myself and I also have this misplaced close button you mentioned. This change in line 3612 in \Core\Core.lua of SavedInstances fixes this issue:

self:SetSize(w * tooltip:GetScale() , (h+20) * tooltip:GetScale())

to

self:SetSize(w * tooltip:GetEffectiveScale() / UIParent:GetEffectiveScale(), h * tooltip:GetEffectiveScale() / UIParent:GetEffectiveScale() + 20 * tooltip:GetScale())

To make this easy I created a pull request in their repository: https://github.com/SavedInstances/SavedInstances/pull/688

tflo commented 1 year ago

SavedInstances […] Additionally I added the styling of these tooltips in TipTac which also handles the scaling itself in the latest release.

SavedInstances tooltip scaling is still bugged for me. Or is the "added the styling of these tooltips" an option I have to enable? (Haven't found one, so far.) Anyways, let's hope they approve your pull request.

Interference with WQAchievements frame is still there for me:

WoWScrnShot_012923_040938

Without TipTac (or with an older version of TipTac), this is just one frame, not 2 split frames like in the screenshot.

Also the health bar is still anchored to the screen bottom:

WoWScrnShot_012923_041059

See the green health bar at the very bottom of the screen? It's the bar that normally is inside TipTac's tooltip frame. This happens also without any other addons enabled.

tflo commented 1 year ago

PS:

For the interference problems with other addons, wouldn't it be a (sort of) solution to limit TipTac's tooltip modifications to the tooltips of action bar buttons, NPCs, world objects, unit frames, chat frame, etc., that is, not touching any other tooltips?

IIRC, TinyTooltip has/had an option for that ("Skin more frames" or something similar)

tflo commented 1 year ago

PS2:

It seems the health bar anchoring has fixed itself, the bar is now back where it belongs to.

What did I do? I forgot to reinstall the pre-23.01.23 version of TipTac and just moved along after posting here, doing some WQs and stuff. So, actually I do not know what has fixed the issue (or if it will come back).

TreizeEU commented 1 year ago

After latest version of TipTac (v23.01.28), I still have the issue with Bulk Mail Inbox's scaling being increased.

hollo6 commented 1 year ago

Also SavedInstances still gets huge after opening it for a second time (they fixed the misaligned close button but the scaling is still an issue).

frozn commented 1 year ago

I created a pull request for WQAchievements to fix the scaling issue: https://github.com/Urtgard/WQAchievements/pull/123

frozn commented 1 year ago

I created a pull request for Titan Panel Socialite to fix another scaling issue: https://github.com/solocommand/Socialite/pull/38

tflo commented 1 year ago

I have only played for an hour or two with your latest version (23.02.06), but so far all the issues from my OP seem to be fixed.

Many thanks for your hard work (and for creating the pull requests at others)!