font keeps resetting

[hollo6]

Describe the bug Every time when closing the game, tooltip font gets reset to Fritz Quadrata TT. Sometimes logging out is enough to make it happen.

To Reproduce Steps to reproduce the behavior:

1. Open TipTac Options
2. Set Font -> Font Face to something else (I'm using Calibri from SharedMediaAdditionalFonts).
3. Close game and start it again.
4. Notice the font is again back to Fritz Quadrata TT.

Expected behavior Font selection should not be reset when logging out or closing the game.

TipTac Reborn (please complete the following information):

• Version 23.01.23

WoW (please complete the following information):

• Flavor: Retail
• Version 10.0.5

Additional context This was working before for a long time, broke with v23.01.23.

[frozn]

Unfortunately I can't reproduce this. After player login (when all addons finished loading) TipTac will check if the chosen font exists. I tested it with fonts which are available on my side, but everything works fine and the font won't be reset.

Btw: I installed SharedMediaAdditionalFonts, but there's no Calibri font included:

[hollo6]

I have added Calibri manually. Maybe a check is needed to see if SharedMedaiAdditionalFonts is already loaded? I have also rolled back to the previous version (v22.12.15) and confirmed that the issue is not present here. calibri.zip

[frozn]

The check for valid fonts and bar textures has just been added with the latest release to prevent some other "strange" errors which appears if there weren't valid.

It take your attached font and give it another try. 🙂

[frozn]

I replaced the SharedMediaAdditionalFonts.lua with your modded one and copied the font in folder fonts. Ingame I checked "Font->Modify the GameTooltip Font Templates" and set font face Calibri. After /reload or completely relogging Calibri is still in place and the GameTooltip is also using this font.

Perhaps it might be another addon interfering here? 🤔

[hollo6]

I don't think it's another addon because only updating this one to a newer version will trigger the issue. I just tried the latest one with today's commits but it's still there. :( /reload and relogging won't break it, only closing the game and restarting it.

[frozn]

Even after closing the game and restarting the font Calibri sticks in place. Tested it under Retail with "Font Flags = None".

[hollo6]

Yes that's what I'm doing, no font flag. Tested it with only TipTac and SharedMediaAdditionalFonts enabled. Still resets on client reopen.

Edit: now I get the following printout on login: TipTac: No valid Font set in option tab Font. Switching to default Font.

[frozn]

This is the error message I added together with the font check.

[hollo6]

So what can I do now to track down this issue?

[frozn]

I don't have a clue actually... 🙁

[hollo6]

Maybe add a (conditional) dependency for SharedMediaAdditionalFonts?

[frozn]

I finally have been able to reproduce this. Setting the font on an FontStringObject doesn't work reliably to check the existance of a font. Instead I create a FontObject directly and this seems to work properly.

Here's the actual dev version: TipTac-dev.zip

Maybe you can test with this version, too?

[hollo6]

Yes! It indeed seems to work now. Thank you for working this out!

[staneezy]

This has worked for me as well. Thank you!