search

frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
108 stars 20 forks source link

Missing Kalu'ak Whalebone Glider in Mount ID tooltips #208

Closed Jeremy7600 closed 1 year ago

Jeremy7600 commented 1 year ago

Describe the bug This item is not presented in the Mount ID Tooltip feature: https://www.wowhead.com/wotlk/item=192455/kaluak-whalebone-glider

To Reproduce Steps to reproduce the behavior:

  1. Find someone riding the Whalebone Glider
  2. Hover over that player's nameplate or target frame
  3. No mount is shown

Expected behavior Should display "Kalu'ak Whalebone Glider (100%)" when a player is riding one

Screenshots Globz riding Kalu'ak Bonewhale Glider, no mount presented in tooltip WoWScrnShot_021923_131742

Tooltip on Globz mount icon WoWScrnShot_021923_131747

TipTac Reborn (please complete the following information):

WoW (please complete the following information):

Jeremy7600 commented 1 year ago

Same for Reawakened Phase Hunter WoWScrnShot_021923_164227 https://www.wowhead.com/tbc/item=184865/reawakened-phase-hunter

I'm guessing there might be another couple

Also, mount speed for these items is dependent on the riders skill. I'd at least like to see the mount, I don't have to see the mount speed since I already have the speed of the target shown (me personally).

frozn commented 1 year ago

The function C_MountJournal.GetMountFromSpell() isn't available in classic. As a fallback I created a plain table by outputting all spells by iterating through C_MountJournal.GetMountIDs() and calling the mentioned function.

Unfortunately some spell IDs of mounts aren't available in retail any more but exist in classic. To solve this I will add the missing spell IDs manually.

frozn commented 1 year ago

I finally added the missing spell IDs. Will be included with the next release. 👍