frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
108 stars 20 forks source link

wrong item icon for compared items #232

Closed frozn closed 1 year ago

frozn commented 1 year ago

From: Xlorida

As of 10.1 when you press shift to compare items, the equiped item icon shown is wrong. Ie you are comparing trinkets and while the compare shows the equiped trinkets, it shows as icon a glove icon.

Source: https://legacy.curseforge.com/wow/addons/tiptac-reborn?comment=301

frozn commented 1 year ago

Confirmed. Tooltip data for ShoppingTooltip1/2 isn't updated after first display. Maybe a blizzard bug in 10.1.0.

frozn commented 1 year ago

This was a tricky one. It's a blizzard bug:

The tooltipData won't be reset for (ItemRef)ShoopingTooltip1/2 because ClearHandlerInfo() won't be called in event OnHide. This call is missing in script handlers of ShoppingTooltipTemplate (see GameTooltip.xml). For GameTooltip this is included in function GameTooltip_OnHide().