frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
108 stars 20 forks source link

Error due to Profession Master #242

Closed darvoso closed 1 year ago

darvoso commented 1 year ago

Receiving below error (from swatter) when I login with new version (23.06.20). Similar to #222, issue goes away if I disable ProfessionMaster, presumably leaking globals still. Did a compare on the two versions, didn't see anything obvious to me to try and resolve, thought I'd ask.


ID: 2
Error occured in: Global
Count: 1
Message: Interface/AddOns/TipTac/ttCore.lua line 828:
   attempt to call method 'SetupConfig' (a nil value)
Debug:
   [string "=[C]"]: SetupConfig()
   [string "@Interface/AddOns/TipTac/ttCore.lua"]:828: ?()
   [string "@Interface/AddOns/TipTac/ttCore.lua"]:853:
      Interface/AddOns/TipTac/ttCore.lua:852
Locals:
(*temporary) = <function> defined =[C]:-1```
Yttrium-tYcLief commented 1 year ago

PM hasn't updated since Wrath 3.4.1's launch and is definitely causing more problems with 3.4.2. The number of globals leaked is pretty insane. I'm going to look into getting this fixed upstream.

These conflicts are bad enough to cause issues with Ace, and it currently breaks a lot from Questie as well.

EDIT: Nothing can be done. Profession Master needs to stop doing what it's doing. Until then, users should uninstall Profession Master and switch to alternatives.

frozn commented 1 year ago

I also took a look into it and came to the following conclusion regarding ProfessionMaster:

66851707

😄

Leaking global Settings in PM smashes WotLKC completely, because the new interface settings has been roled out with the new version 3.4.2.

EDIT: Nothing can be done. Profession Master needs to stop doing what it's doing. Until then, users should uninstall Profession Master and switch to alternatives.

Indeed

darvoso commented 1 year ago

Well, apparently! It got resolved. https://www.curseforge.com/wow/addons/profession-master/files/4601211 -> Notes: 1.6.4 Fixed global settings issue. Many thanks to @Ulidan And now when I fire up the ol PM with tiptac and such, nothing splodes. Thank you both for taking a look - i didn't realize there was a discord posted on the PM list to reach out to that dev.