frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
119 stars 25 forks source link

Mouseover on hunter in Classic Season of Discovery error #268

Closed Jeremy7600 closed 8 months ago

Jeremy7600 commented 10 months ago

Describe the bug 62x SharedXML/Color.lua:61: bad argument #2 to 'format' (string expected, got nil) [string "=[C]"]: in function `format' [string "@SharedXML/Color.lua"]:61: in function <SharedXML/Color.lua:60>

[string "@TipTacTalents/ttTalents.lua"]:308: in function callback' [string "@TipTac/libs/LibFroznFunctions-1.0-15/LibFroznFunctions-1.0.lua"]:2558: in functionFinishInspect' [string "@TipTac/libs/LibFroznFunctions-1.0-15/LibFroznFunctions-1.0.lua"]:2549: in function FinishInspectDataAvailable' [string "@TipTac/libs/LibFroznFunctions-1.0-15/LibFroznFunctions-1.0.lua"]:2523: in functioncallbackForItemData' [string "@TipTac/libs/LibFroznFunctions-1.0-15/LibFroznFunctions-1.0.lua"]:3019: in function LFF_GetAverageItemLevelFromItemData' [string "@TipTac/libs/LibFroznFunctions-1.0-15/LibFroznFunctions-1.0.lua"]:2795: in function <...libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua:2791> [string "=[C]"]: in functionxpcall' [string "@FrameXML/ObjectAPI/Item.lua"]:298: in function `FireCallbacks' [string "@FrameXML/ObjectAPI/Item.lua"]:260: in function <FrameXML/ObjectAPI/Item.lua:256>

Locals: (temporary) = "|c%s%s|r" (temporary) = "ff000000" (temporary) = nil (temporary) = "string expected, got nil"

To Reproduce Steps to reproduce the behavior:

  1. Mouse over hunter character (not all hunters, but I've only noticed it with hunters)
  2. See error

Expected behavior No error when mousing over a player in the world or their frame.

TipTac Reborn (please complete the following information):

WoW (please complete the following information):

Additional context Can't tell what is triggering it, could be a hunter rune in the new Season.

Jeremy7600 commented 10 months ago

Had it happen on a druid just now, so not just hunters

frozn commented 10 months ago

Thanks for reporting this! đź‘Ť

I changed the code to consider situations where a player's GearScore couldn't be determined properly.

Will be included in the next release.