frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
107 stars 20 forks source link

Player names are missing from tooltips #273

Closed hollo6 closed 3 months ago

hollo6 commented 5 months ago

Describe the bug Since 10.2.5, player tooltips from party/raid frames are missing player names, only the realm is being shown.

To Reproduce Steps to reproduce the behavior:

  1. Be in a party with somone that is out of range
  2. Hover over that player on the party frame
  3. Observe missing player name

Expected behavior Player names should be shown regardless of distance, like before.

Screenshots image

TipTac Reborn (please complete the following information):

WoW (please complete the following information):

Additional context Never seen this problem before 10.2.5.

frozn commented 5 months ago

Thanks for reporting this! 👍

Unfortunately I haven't been able to reproduce this yet. I grouped with someone and teleported somewhere out of range, but the player name is still visible.

Is this only related to dungeons/raids, because I tested this in the open world?

hollo6 commented 5 months ago

I think you should be out of range when entering the group, once you're in range, the tooltip will show the name even if you go away. And it's like this before entering any dungeon/raid, when everyone in the group is still in (any) open world area.

Vilogity commented 5 months ago

Same here, join Group and only see Server Name when out of range. The only one I see was the druid he was also in valdraken. Never had this before !!

Is this only related to dungeons/raids, because I tested this in the open world? For me yes

DaleHuntGB commented 5 months ago

This happened to me as well.

Out of Range Players just return nothing at all.

My assumption, because there's no error, it is likely to do with either determining class colour and failing so the string is just empty or it'll be something weird with server name.

Other than that, not entirely sure what's happening but as I said, no errors when hovering over the players, just returns a blank string (that's what it seems like).

EDIT: This seems to have nothing to do with class colour or not. Toggled all options off, still just returns - SERVER, however, weirdly, one of the players worked.

hollo6 commented 5 months ago

The only one I see was the druid he was also in valdraken. Is this only related to dungeons/raids, because I tested this in the open world? For me yes

Then the answer is no because Valdrakken is open world, not a dungeon or raid.

My assumption, because there's no error, it is likely to do with either determining class colour and failing so the string is just empty or it'll be something weird with server name.

It's not class color, the borders and text are always shown and colored correctly, just like in my screenshot above. And it is not just one server name, it's ALL server names - also, even if there is no server name because the player is from the same realm, their name is missing just as well. In that case the first line in the tooltip is just blank.

Vilogity commented 5 months ago

The only one I see was the druid he was also in valdraken. Is this only related to dungeons/raids, because I tested this in the open world? For me yes

Then the answer is no because Valdrakken is open world, not a dungeon or raid.

My assumption, because there's no error, it is likely to do with either determining class colour and failing so the string is just empty or it'll be something weird with server name.

It's not class color, the borders and text are always shown and colored correctly, just like in my screenshot above. And it is not just one server name, it's ALL server names - also, even if there is no server name because the player is from the same realm, their name is missing just as well. In that case the first line in the tooltip is just blank.

I mean this is only happen to me when I join Group.......the druide from the Group was in my near. Today I see IN Group........nothing...no name or Server, then when we all together in Instance all ok.

frozn commented 5 months ago

What do you have set in options under "General->Name & Title"?

I'm currently "under heavy development" regarding some other issues with df patch 10.2.5 and jumped into playing more WoW again after a sidetrip to Diablo IV. So I will further try to reproduce this. 🙂

hollo6 commented 5 months ago

What do you have set in options under "General->Name & Title"?

Name + title.

But this happens for everyone, regardless if they have a title shown or not.

Vilogity commented 5 months ago

For me, it's allways there....... Allways when joining a Group.

DaleHuntGB commented 5 months ago

This seems to be a more global problem, as ElvUI has the same issue with their tooltips.

This is one of the commits that seemingly fixes that issue - ElvUI Dev: Tooltip Fix

frozn commented 5 months ago

Thanks @DaleHuntGB for this hint!

I have been able to reproduce this with a random world quest group. The missing unit name is only an issue if "General->Name & Title" has been set to "Name + title". In this case api function UnitPVPName() returns nil or "" for unit's name with title in case the unit is currently not visible to the client.

Because I always play with "Name only", I haven't noticed this yet. Here the unit name will be determined with UnitName(), which always returns a valid unit name.

Fix will be included in the next release! 👍

hollo6 commented 5 months ago

Looks good now, thanks!