frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
107 stars 20 forks source link

CPU spikes when mouse over certain types of items #284

Closed Road-block closed 1 month ago

Road-block commented 1 month ago

Describe the individual topic

For some time I've been experiencing significant FPS drops when mouse over items in bags, some types of items more significant than others.

Logic says if it happens with mouseover it must be a tooltip addon.

In the end I enabled cpu tracking and used addonusage to quantify it.

CPU tracking itself causes an even greater performance hit but even accounting for that the results are pretty clear.

FPS drop without cpu tracking enabled is 128 (capped) > 20-30 fps, with cpu tracking the game becomes a slideshow 128 > 2-3 fps.

As you can see in the attached screenshot TipTac is the biggest offender. tiptac-cpu Example item tiptac-cpu-2

Road-block commented 1 month ago

I will do some isolation tests with TipTac the only addon running and then try with some of its optional modules disabled, but it's not looking good 😞

Road-block commented 1 month ago

I disabled every addon that touches the tooltip (RatingBuster and its Statlogic library, Pawn, Bag addon tooltip additions, Auction addon tooltip additions, all the addons that would put anything on the tooltip.

The situation improved somewhat - as expected, any addon that does something wtth the tooltip will use some cpu can't have functionality with zero cost, but I still lose 20-25 FPS when mouse over certain item types with TipTac and TipTacItemRef being the only relevant addons.

tiptac-cpu-3

frozn commented 1 month ago

I reviewed TipTacs coding but I don't see anything special here which would improve the cpu load significantly. 🤔

I installed addon AddOns CPU Usage to check it for myself. With CPU tracking enabled I currently have 110 fps, and when I hover over an item in my bag where the 2 compare tooltips pop up too, I have 104fps. So on my side the fps only drop by 6 fps or 94% of the original fps.

Road-block commented 1 month ago

It's probably compounded with more addons adding stuff to the tooltip. Thanks for taking a look 😃

If you ever want to come back to this, maybe test a bit with some of the very popular addons that add to the tooltip (Rating Buster + Pawn that I already mentioned come to mind)