search

frptools / collectable

High-performance immutable data structures for modern JavaScript and TypeScript applications. Functional interfaces, deep/composite operations API, mixed mutability API, TypeScript definitions, ES2015 module exports.
MIT License
273 stars 14 forks source link

LIST(impl): Add map implementation #51

Closed SimonMeskens closed 7 years ago

SimonMeskens commented 7 years ago

Can I get a code review to see if these are the kinds of PRs you want? I'm versed in rebase if you need changes to the commit structure too.

axefrog commented 7 years ago

Sorry for the slow reply (Sunday and whatnot). Going to review this now. On a side note, do you by any chance have Docker set up on your local machine? Travis is failing and nobody I know can seem to reproduce the error that Travis is reporting. See: https://travis-ci.org/frptools/collectable/jobs/259185345 Apparently if you run the Travis test instance in Docker, it'll reproduce the issue successfully. Unfortunately my machine seems to fail when installing prerequisites for Docker, so I haven't been able to figure the issue out yet, which means that pull requests always show up as build failures.

axefrog commented 7 years ago

Code's all good, and builds fine for me locally. Merged. Thanks!

SimonMeskens commented 7 years ago

Unfortunately, Docker doesn't want to install on my machine either and I haven't been able to find out why.

Thanks for the review, I'll move on to some more challenging PRs (wanted to make sure I understood the PR process first).

axefrog commented 7 years ago

Travis is finally building. Your future PRs should now actually reflect this.

SimonMeskens commented 7 years ago

Thanks, that's helpful