search

frptools / collectable

High-performance immutable data structures for modern JavaScript and TypeScript applications. Functional interfaces, deep/composite operations API, mixed mutability API, TypeScript definitions, ES2015 module exports.
MIT License
273 stars 14 forks source link

If yarn is preferred, why not commit the yarn.lock file? #57

Closed ariesshrimp closed 7 years ago

ariesshrimp commented 7 years ago

In the CONTRIBUTING doc, it's mentioned that it's best to install and build the packages using yarn. But there isn't a yarn.lock file committed in the codebase. Is there a reason not to? yarn.lock is not listed in the .gitignore or .npmignore files.

SimonMeskens commented 7 years ago

The build changed very recently to NPM5

ariesshrimp commented 7 years ago

I assume that means you don't want to instruct people that they should be using yarn any longer?

SimonMeskens commented 7 years ago

I'm not sure, I just came along right before you to help with some code, so I went through the same process and know some of the answers :)

@axefrog Has all the answers, but I think he's having a rather busy week, so we'll be patient for a bit

axefrog commented 7 years ago

Hey guys, sorry for my absence. Had the flu, felt like death, etc.

Simon is right. The parts of the CONTRIBUTING doc related to implementation specifics and the build process are outdated. References to commit standards and other conventions still apply though.