search

frqnny / mostructures

Mo' Structures is Fabric's best structure mod, carefully designed to enrich your world with many fun adventures to be had!
GNU Lesser General Public License v3.0
72 stars 16 forks source link

1.18 attempt #61

Closed frqnny closed 2 years ago

frqnny commented 2 years ago

1.18 attempt.

Hey @filips123 do I have your permission to merge and release this please? you fixed the volcanic vent issue so I kinda wanna release it. this is also asking for permission as the current 1.18 release I did on curseforge was your fork and I didn't ask about that one and I feel kinda guilty.

filips123 commented 2 years ago

Yes, you can merge it. In any case I intended to contribute it to this repo, so it's fine.

However, I'm not actually sure if the volcanic vent is completely fixed. I was recently upgrading one world from 1.17.1 to 1.18.1 (Mo' Structures were installed both in the original 1.17 version and when upgrading to 1.18), and some volcanic vents were generated outside the ocean. I think those volcanic vents generated around the edge of the pre-1.18 world, so maybe it's just caused by some problems in world blending, but to be safe, they should probably still be disabled in config until this is fixed. Maybe the proper fix is to check if they will generate completely underwater, but I'm not sure if this is possible.

Screenshots ![2021-12-29_13 13 25](https://user-images.githubusercontent.com/16626308/147661240-13febc13-d043-4b56-b599-d6daad425c4c.png) ![2021-12-29_13 13 36](https://user-images.githubusercontent.com/16626308/147661242-b50ee711-de90-4b83-b284-b9240d59b959.png) ![2021-12-29_13 14 10](https://user-images.githubusercontent.com/16626308/147661244-1d8bcc31-7e62-44b5-b94a-336ae7e23589.png)
filips123 commented 2 years ago

I tested Volcanic Vent on the same seed as before, but with a fresh world, and it didn't generate outside the ocean (or at least I didn't found it). Considering this is probably some bug/problem in vanilla world blending, and upgrading modded worlds probably isn't so common, I think it should be fine and this PR can be merged.