search

fruch / pytest-elk-reporter

A plugin to send pytest test results to ELK stack
MIT License
18 stars 12 forks source link

reword, typos, grammar, etc #20

Closed gaucheph closed 3 years ago

gaucheph commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #20 (994fb64) into master (33afcba) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files           1        1           
  Lines         263      263           
=======================================
  Hits          247      247           
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33afcba...994fb64. Read the comment docs.

gaucheph commented 3 years ago

hey @fruch! i like the project and i think it's tremendously valuable. i noticed some typos in the readme and started to fix them but then also "fixed" a few other things. let me know what you think :)

fruch commented 3 years ago

hey @fruch! i like the project and i think it's tremendously valuable. i noticed some typos in the readme and started to fix them but then also "fixed" a few other things. let me know what you think :)

Hi @gaucheph I really happy you find it helpful, I'll surely going to merge those.

Also it would be nice to hear a bit more about the use case you have for it, since just yesterday I've got a CFP accepted to talk about this project (in https://pycon.org.il), and it's a great timing to have some written "testimonial" (snapshot of graphs or dashboards, would be a great bonus)

if you can contact me on israel.fruchter@gmail.com, or on https://twitter.com/IsraelFruchter, would love having a quick chat if you have a few minutes to spare.