search

fruggy83 / openocean

27 stars 12 forks source link

Add support for Hora SmartDrive MX #63

Open dominikkv opened 5 years ago

dominikkv commented 5 years ago

The SmartDrive uses EEP A5-20-04, which has to be created. Furthermore, we need the ability to respond to incoming telegrams, which means in detail:

This can be used later for SmartACK support.

hazardous-silence commented 5 years ago

Hi, I've been following the evolution of this project from far away for quite some time now. I have a "EEP A5-20-01" device for about a year now but I was hoping to use it with OpenHAB. Do you think you will implement this feature any soon? I'm a java developer, do you have a rough idea how much work it could be for me to implement this profile (I'm completely new to the code side of OpenHAB)? Thanks

fruggy83 commented 5 years ago

Hi @hazardous-silence, I have nearly finished my SMACK implementation, which also supports the needed Reclaim/Response communication schema of this EEP. Maybe I can push the first version this weekend. Best regards Daniel

thyzoul commented 5 years ago

Hi, Sounds great, thanks

Le jeu. 17 oct. 2019 à 10:21, Daniel Weber notifications@github.com a écrit :

Hi @hazardous-silence https://github.com/hazardous-silence, I have nearly finished my SMACK implementation, which also supports the needed Reclaim/Response communication schema of this EEP. Maybe I can push the first version this weekend. Best regards Daniel

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fruggy83/openocean/issues/63?email_source=notifications&email_token=AIZ66KOTKMHEEK45MF4A6Q3QPAOALA5CNFSM4G4HTER2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBPH2RA#issuecomment-543063364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZ66KNE5IC5JMZIX2RQK33QPAOALANCNFSM4G4HTERQ .

fruggy83 commented 5 years ago

Hi all,

I have just pushed the SMACK feature branch (issue_64). @dominikkv I have automated the request/response process a little bit. After receiving a message, I trigger the CHANNEL_STATUS_REQUEST_EVENT, wait 100ms and handle the CHANNEL_SEND_COMMAND afterwards. The user has 100ms time to recalculate the item states. Furthermore CHANNEL_SEND_COMMAND does not need to be linked any longer. If it is ok, I would remove convertToEventImpl from A5-20-04 EEP, and just send an answer after any received message. If the actuator did not requested an status update it should just ignore the answer from the binding. @hazardous-silence I will push the A5-20-01 EEP in the next few days, after @dominikkv gives me a thumb up for my proposal.

Best regards Daniel

dominikkv commented 5 years ago

Hey Daniel, I'm fine with that 👍 Thanks for your great work!

fruggy83 commented 5 years ago

Hi @dominikkv, thanks a lot for your feedback. @hazardous-silence I will push my implementation of A5-20-01 EEP and release a new beta for testing in the next days.

hazardous-silence commented 5 years ago

Hello, this sounds great ! Thanks a lot !

fruggy83 commented 5 years ago

Hi @hazardous-silence,

if just released a new version of this binding here. This version contains EEP A5-20-01. It would be nice if you could test it.

What should work by now:

Whats not supported by now:

Waiting for your testing results. Thanks a lot for your effort.

hazardous-silence commented 5 years ago

Hi, First of all, thanks a lot! As I'm new to the OpenHab I'm guessing I'm limited due to my OpenHab knowledge. Anyway, I haven't managed to set up the Thing. I think I'm failing with the teach In phase.

My valve is a Micropelt MVA004. I've set up a docker openhab (snapshot-debian). I've connected an USB300 (/dev/ttyUSB0) and that seems to work correctly. Then, in PaperUI, I did "Inbox > Binding > Search" and while it was searching I pressed the valve button then the interface proposes me to add a Generic Thing but my valve gives me three red flashes telling me the pairing failed. I tried to do the manual creation of the Thermostat Thing but the pairing doesn't work either.

I'm keen on debugging but I'd need some indications on the best way to move on.

Thanks a lot, Regards

hazardous-silence commented 5 years ago

Hi, just some additional feedback. I have activated DEBUG add seen that the "**.enocean.internal.eep.EEPFactory" class logged a message saying: Received unsupported EEP teach in, fallback to generic thing." So I lock at the code and understood that the EEPType class I was using didn't import any A5-20-01 epp. So I understood my container doesn't have the right enocean binding jar. What mislead me is that your new jar is named with the same version as the one I am using : "org.openhab.binding.openocean-2.5.0-SNAPSHOT.jar" though the new one is technically a "2.5.0.3-alpha". I will soon deploy this new version and let you know!

Sorry for that, Regards

hazardous-silence commented 5 years ago

Hi, I deployed the new enocean binding and got pretty further 👍 Now I'm blocked with the following : 00:22:57.981 [DEBUG] [ernal.handler.EnOceanBaseThingHandler] - initializeThing thing enocean:thermostat:FT3G3JFS:0516D800 bridge status ONLINE 00:22:58.018 [INFO ] [ome.event.ThingStatusInfoChangedEvent] - 'enocean:thermostat:FT3G3JFS:0516D800' changed from INITIALIZING to OFFLINE (CONFIGURATION_ERROR): Sending EEP is not supported

I'll take a look at the concerned classes at some point this week. Regards

fruggy83 commented 4 years ago

HI @hazardous-silence,

I found a typo in my EEPType collection. I will upload a new version in the next few days. Sorry for the trouble.

fruggy83 commented 4 years ago

@hazardous-silence By the way according to the docs, the MVA004 does not support SMACK but needs the reclaim/response message process implemented by this issue. So you do not need to activate the SMACK of your gateway.