fruitflybrain / neu3d

A javascript 3D visualization engine for neural data in SWC format
7 stars 8 forks source link

Remove dependency on container.id #4

Closed TK-21st closed 5 years ago

TK-21st commented 5 years ago

This Code Block

    $('#' + this.container.id).on({
      'dragover dragenter': function (e) {
        e.preventDefault();
        e.stopPropagation();
      },
      'drop': function (e) {
        let dataTransfer = e.originalEvent.dataTransfer;
        if (dataTransfer && dataTransfer.files.length) {
          e.preventDefault();
          e.stopPropagation();
          $.each(dataTransfer.files, function (i, file) {
            let reader = new FileReader();
            reader.onload = $.proxy(function (file, event) {
              if (file.name.match('.+(\.swc)$')) {
                let name = file.name.split('.')[0];
                let json = {};
                json[name] = {
                  label: name,
                  dataStr: event.target.result,
                  filetype: 'swc'
                };
                ffbomesh.addJson({ ffbo_json: json });
              }
            }, this, file);
            reader.readAsText(file);
          });
        }
      }
    });

was written to enable drag-dropping files onto the neu3d widget relies on container.id being specified because it uses JQuery.

Change this to use JavaScript's native method, see here

TK-21st commented 5 years ago

fixed in https://github.com/fruitflybrain/neu3d/commit/8d90341fac9d8a6024c8e813e60ef3997dba8da7