fruitl00p / php-mt940

A mt940 parser in PHP
MIT License
103 stars 60 forks source link

KNAB fixes #32

Closed fruitl00p closed 8 years ago

fruitl00p commented 8 years ago

I've updated the KNAB parser based on private test file provided by KNAB

I've also implemented the start/end timestamp and price handling

fruitl00p commented 8 years ago

@SamMousa can you test your KNAB data with this PR? It should all work as intended as we now have some test data... but i'd like to make sure...

Thanks!

SamMousa commented 8 years ago

It's on my todo list.

fruitl00p commented 8 years ago

:+1:

robgeerts commented 8 years ago

KNAB has the option to export to 2 different MT940-files (the old one and a new structured one, I think as mentioned above. But the new one doesn't work. Is there a fix available?

fruitl00p commented 8 years ago

@robgeerts have you tried this new version of the code? This should support the newer structured MT940 format...

robgeerts commented 8 years ago

Yes, I've downloaded the code yesterday. With the old structured MT940 it works as expected.

SamMousa commented 8 years ago

@robgeerts Thanks for testing it, @fruitl00p, could this then be merged? And maybe a separate issue should be opened for the structured file?

fruitl00p commented 8 years ago

LGTM :+1:

robgeerts commented 8 years ago

Thanks but it doesn't work... for example, you're searching for REK: and NAAM: but both are not correct, in my MT940 from Knab it uses /NAME/, this is an example:

:61:1604290429D96,84N105NONREF//B6D29PGWUM0RDZ4H :86:/TRTP/SEPA ACCEPTGIRO/IBAN/NL83ABNA0437015300/BIC/ABNANL2AXXX /NAME/ACHMEA SCHADEVERZEKERINGEN N.V./EREF/5002100023310160 /REMI/EERSTE MAAND, MAART VERZEKERING 5002100023 310160

SamMousa commented 8 years ago

Are you referring to the structured or unstructured file?

KNAB has the option to export to 2 different MT940-files (the old one and a new structured one, I think as mentioned above. But the new one doesn't work. Is there a fix available?

You said the old one works. This PR was about the old one; so that is why it has been merged.

For the new file which has a different format, a new issue should be created.

robgeerts commented 8 years ago

Ok, sorry, I was talking about the new (structured) file.. I'll create a new issue..