fryette / webview_cookie_manager

MIT License
48 stars 52 forks source link

Fix null domain errors #35

Closed Mol0ko closed 3 years ago

Mol0ko commented 3 years ago

Related issue #34

Fixes runtime error in case Cookie has no domain on the Dart side. Also added tests on native (android and ios) side as errors occur there.

IMPORTANT NOTE: Domain attribute is not required according to RFC, but it is important to remember that empty domain causes undefined behavior. So it is highly reccommended to specify it this this way:

final cookie = Cookie('cookieName', 'cookieValue')..domain = 'youtube.com';

Probably this note should be added to readme.

fryette commented 3 years ago

Thanks for your contribution!