search

fryette / webview_cookie_manager

MIT License
48 stars 52 forks source link

feat: add origin url parameter #43

Closed jeiea closed 3 years ago

jeiea commented 3 years ago

On android I found that if a cookie's domain attribute contains scheme(https://) that cookie is not applied. On the other hand scheme is required in domain string if secure attribute is set. Currently this library cannot use secure attribute because it use domain attribute in both setCookie's url parameter and domain attribute. They have different scheme requirement.

This PR introduces origin named parameter in setCookie for the above.

fryette commented 3 years ago

First of all thanks for your contribution!

Will take a look at it this week.