fryette / webview_cookie_manager

MIT License

48 stars 52 forks source link

Update WebviewCookieManagerPlugin.java #7

Closed jiechic closed 4 years ago

jiechic commented 4 years ago

fix if cookie is null will throw exception

jiechic commented 4 years ago

8 for fix null exception

fryette commented 4 years ago

LGTM

rodruiz commented 4 years ago

Maybe a ternary operator here looks better.

final ArrayList<String> individualCookieStrings = allCookiesString == null ? new ArrayList<>() : new ArrayList<>(Arrays.asList(allCookiesString.split(";")));

rodruiz commented 4 years ago

You have to update

[x] pubspec.yaml
[x] CHANGELOG.md

fryette commented 4 years ago

@rodruiz Updated to the ternary operator New version already available

jiechic commented 4 years ago

@rodruiz Updated to the ternary operator New version already available

Two definitions, no errors in the compilation process?

fryette commented 4 years ago

Oy shit) will fix, thx @jiechic