frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
769 stars 224 forks source link

Hydro Swirl is able to Vaporize when it should not. Burning is not able to Vape and Melt when it should* #1094

Open PolomoPT opened 1 year ago

PolomoPT commented 1 year ago

Some transformative reactions are able to have amplifying reactions when they should not, and vice versa. These are Hydro Swirl, which should not be able to Vaporize, and Burning, which should. (Edit: Is it worth possible confusion to allow Vaped and Melted Burning?)

Please refer to comments >April 2nd for explanation.

littlef0x commented 1 year ago

Some of them can. For example, Cryo Swirl damage can trigger melt reaction when hitting an enemy with Pyro element. But this melt damage cannot crit.

Melee infusion doesn't exist for transformative reactions.

PolomoPT commented 1 year ago

Well, than that's a whole 'nother problem. The Melt/Vape dropdowns only show up when a melee infusion is active. It would need to be made so it always shows up, then, or something.

Em qua, 22 de mar de 2023 05:06, littlef0x @.***> escreveu:

Some of them can. For example, Cryo Swirl damage can trigger melt reaction when hitting an enemy with Pyro element. But this melt damage cannot crit.

Melee infusion doesn't exist for transformative reactions.

— Reply to this email directly, view it on GitHub https://github.com/frzyc/genshin-optimizer/issues/1094#issuecomment-1479072151, or unsubscribe https://github.com/notifications/unsubscribe-auth/A45SEZ35AUUNKQLDFBXRV43W5KXGTANCNFSM6AAAAAAWDF4Z6Y . You are receiving this because you authored the thread.Message ID: @.***>

littlef0x commented 1 year ago

The Melt/Vape dropdowns only show up when a melee infusion is active.

That's because the damage itself isn't Pyro/Cryo/Hydro. If it is, the dropdown will show up even if melee infusion is not active. 图片

It's OK to not show it for other types of damage. The problem is melee infusion rather than Amplifying reaction. Melee infusion should not appear for transformative reactions.

BTW, the Avg. DMG dropdown should also be removed for transformative reactions since such damage cannot crit.

PolomoPT commented 1 year ago

image Hydro Swirl damage should not be able to Vaporize.

Convoluted explanation: According to KQM TCL, In the special case of Hydro, only the target afflicted with the Hydro initially will take damage as the dispersion of Hydro will not harm enemies. This means that only enemies that were Swirled take damage. Enemies that were Swirled cannot have had Pyro on them, otherwise the Swirl would have been Pyro. While it can trigger Vaporize, technically, the damage dealt is actually 0 in such cases, as damage dealt to enemies not Swirled is 0, which is not the value taken into account by GO. So it should not allow for Vape at all.

Unga Bunga: Enemy with water take damage but no vape Enemy with fire vape but no take damage

littlef0x commented 1 year ago

In the special case of Hydro, only the target afflicted with the Hydro initially will take damage as the dispersion of Hydro will not harm enemies.

Ah, that's right. Sorry, I forgot that.

So there should be 6 reactions available for Transmative reaction:

PolomoPT commented 1 year ago

image KQM confirms the Burning aspect, not sure if worth fixing.

PolomoPT commented 1 year ago

renamed in order to display the greater issue first