frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
784 stars 233 forks source link

Conditionals and Optimization settings aren't being saved per Loadout #1561

Closed StainAE86 closed 8 months ago

StainAE86 commented 8 months ago

As per title. They're being applied globally to the Team. Example:

Setup a Loadout for "Cryo" Kaeya, with his C1 active, Cryo Goblet, 140% ER and only 4PC Blizzard Strayer: image image image

If you then create a second loadout for "Physical", turning off C1, Changing to Phys Goblet, removing the Constraint and enabling more artifact sets: image image image

And then swap back to your "Cryo" loadout, all the settings retain the changes you last made to suit the "Physical" loadout because they're following the global "Team" setting, rather than the "Loadout": image image

It is only the artifacts that are being saved to the loadout.

Likely the same bug as this: https://github.com/frzyc/genshin-optimizer/issues/1545#issuecomment-1963092351

frzyc commented 8 months ago

Yes, that is part of the design. Please read the design doc.

image

If you have a different context for a character, create a new team with a new loadout.