search

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
775 stars 228 forks source link

after v10 migration clean up #2004

Open StainAE86 opened 5 months ago

StainAE86 commented 5 months ago

there are still quite a number of users who havent cleaned up their database after the loadouts migration either due to feeling its too big of a task, not knowing how or simply not understanding how the teams->loadouts->builds system even works.

the UI is still very much lacking in the tools to easily manage teams and loadouts in particular in bulk. infact it has gotten even harder as the UI has evolved since the initial patch.

while I understand you want to give the user context of what they're deleting when trying to remove what is percieved as a unused/unnessacary loadout or team. I believe the tools are at least required.

one suggestion would be adding some bulk management under the database menu on the settings page.

this popup could be updated to include a counter for teams and loadouts, add buttons to "delete empty loadouts" and "delete empty/solo teams" and these additions made accessable even outside of uploading a new database as well. image

I would define an "empty" loadout as one that does not have: builds, multi-targets or opt-target selection. as the migration process added a loadout for every character used as a team mate; and their team buffing conditional states.

frzyc commented 5 months ago

In theory the amendment to the migration logic in https://github.com/frzyc/genshin-optimizer/pull/2021 should get rid of a lot of these cases. Existing migrated databases may still need these tools, the theory is that users who care will already have dealt with this manually. Not sure if its worth the effort to implement. Will observe user feedback over the coming weeks.

StainAE86 commented 5 months ago

I think adding the tools to aid in cleanup is more worthwhile than improving the migration logic?

The initial migration took place long enough ago now that the vast majority of GO users have already had their databases put into this messy state. Sure those who care enough have probably fixed their database by now - but it would still be a larger percentage of users who havent fixed vs those who havent even done the migration in the first place?