Hide AdCard when closing AdWrapper - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

777 stars 228 forks source link

Hide AdCard when closing AdWrapper #2102

Closed CordonZeus22 closed 4 months ago

CordonZeus22 commented 4 months ago

Describe your changes

Prevent cut off the Set Config when closing the ad on the Artifact Upgrader

Issue or discord link

Resolves #2092

Testing/validation

https://github.com/frzyc/genshin-optimizer/assets/70012600/40f7389a-86e7-4bd2-9ec1-d7e1befe6ac2

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 4 months ago

[frontend] [Sat May 11 16:36:53 UTC 2024] - Deployed 9c121df247f25b86ea71ed974e455dae615212fc to https://genshin-optimizer-prs.github.io/pr/2102/frontend (Takes 3-5 minutes after this completes to be available)

[Sat May 11 17:21:54 UTC 2024] - Deleted deployment