Add bulk management to weapons page and filter by lock status

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

751 stars 219 forks source link

Add bulk management to weapons page and filter by lock status #2111

Closed CordonZeus22 closed 2 months ago

CordonZeus22 commented 2 months ago

Describe your changes

Add buttons for bulk management (lock, unlock, delete) to weapons page. Add filters (lock, unlock, inventory, equipped) to weapons page. Make small changes to the layout for a better consistency with the artifacts page.

Issue or discord link

Closes #1041

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 2 months ago

[frontend] [Sun May 12 21:59:08 UTC 2024] - Deployed b25c36c0736f82ece6949ff577d6cc698bd0c4d5 to https://genshin-optimizer-prs.github.io/pr/2111/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 12 22:00:29 UTC 2024] - Deployed 49a9d4960c079fae0c92a380b7fcd86964db2c31 to https://genshin-optimizer-prs.github.io/pr/2111/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 13 13:04:13 UTC 2024] - Deployed b364d45d0be5b551b748958c80b364da5d5e1e47 to https://genshin-optimizer-prs.github.io/pr/2111/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 13 14:41:20 UTC 2024] - Deployed e774450ac246f8b5af195d94cc6415a06e602950 to https://genshin-optimizer-prs.github.io/pr/2111/frontend (Takes 3-5 minutes after this completes to be available)

[Mon May 13 15:53:28 UTC 2024] - Deleted deployment

CordonZeus22 commented 2 months ago

If you are fine leaving this as is for this PR, I will do another PR for adding the character location fillter.

Also, on the artifact page, the reset button doesn't reset the sort, but on weapon page it does, which behavior is the correct one ?

frzyc commented 2 months ago

Also, on the artifact page, the reset button doesn't reset the sort, but on weapon page it does, which behavior is the correct one ?

I think it makes sense for the "reset" button to only reset the elements inside its card. in this case, the reset on the weapon page should not reset the sort.

CordonZeus22 commented 2 months ago

I will change it

CordonZeus22 commented 2 months ago

Done