Allow search field to search 2/4-piece field for artifacts in archive - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

777 stars 228 forks source link

Allow search field to search 2/4-piece field for artifacts in archive #2112

Closed chengxi600 closed 4 months ago

chengxi600 commented 4 months ago

Describe your changes

Search field in Archive also filters by 2 piece and 4 piece set effect description.

Issue or discord link

Resolves https://github.com/frzyc/genshin-optimizer/issues/1998

Testing/validation

https://github.com/frzyc/genshin-optimizer/assets/23622319/99cc1c01-c3c1-468f-bc0f-671c6fd3d1f5

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 4 months ago

[frontend] [Sun May 12 22:20:07 UTC 2024] - Deployed f3fe50d4b77fa5724542720c5a4dbd756045976d to https://genshin-optimizer-prs.github.io/pr/2112/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 12 22:38:56 UTC 2024] - Deployed 2fc05f2146f1a5b05bbdc8e79c50916b82837453 to https://genshin-optimizer-prs.github.io/pr/2112/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 12 22:48:14 UTC 2024] - Deployed f8db5b2554d73d92605801318728d20ecff3e3fb to https://genshin-optimizer-prs.github.io/pr/2112/frontend (Takes 3-5 minutes after this completes to be available)

[Sun May 12 23:44:17 UTC 2024] - Deleted deployment