search

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
751 stars 219 forks source link

Archive page needs to have browser history friendly routing #2125

Closed frzyc closed 2 months ago

frzyc commented 2 months ago

Currently navigating from any page into the archive page disallow going back in history, likely due to the /archive->/archive/artifact path. routing to /archive and then to a tab should replace history, instead of adding onto it.

chengxi600 commented 2 months ago

@frzyc would this be okay having /archive also point to the artifact tab? This fixes the history issue I think but would make the /archive/artifacts path redundant. Not sure if this is good practice.

frzyc commented 2 months ago

@frzyc would this be okay having /archive also point to the artifact tab? This fixes the history issue I think but would make the /archive/artifacts path redundant. Not sure if this is good practice.

I think this is the only solution, having an empty page is probably more harmful.