Allow filtering by secondary stat in archive

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

777 stars 228 forks source link

Closed CordonZeus22 closed 4 months ago

CordonZeus22 commented 4 months ago

Add a SubStat filter to the weapon page in archives.

Should I add a filter for no-substat ?

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 4 months ago

[frontend] [Wed May 15 13:30:33 UTC 2024] - Deployed 8cbce34a342c1248f80de3308dd59cd967a92621 to https://genshin-optimizer-prs.github.io/pr/2137/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed May 15 19:31:13 UTC 2024] - Deployed 3acd4b51c3f757e0a418ca1121a4c45adb04a2c2 to https://genshin-optimizer-prs.github.io/pr/2137/frontend (Takes 3-5 minutes after this completes to be available)

[Thu May 16 06:50:06 UTC 2024] - Deleted deployment

frzyc commented 4 months ago

"no substat" is only for 1/2 weapons, so I think leaving them out is fine imo.

CordonZeus22 commented 4 months ago

So filtering them out if the substat filter is used ?

frzyc commented 4 months ago

So filtering them out if the substat filter is used ?

yes, that should work.

CordonZeus22 commented 4 months ago

I can't request a review