Delete button on Team Card - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

751 stars 219 forks source link

Delete button on Team Card #2143

Closed chengxi600 closed 1 month ago

chengxi600 commented 1 month ago

Describe your changes

Added delete button to Teams Card. Moved TeamDelModal to @genshin-optimizer/gi/ui

Issue or discord link

Resolves https://github.com/frzyc/genshin-optimizer/issues/2132

Testing/validation

https://github.com/frzyc/genshin-optimizer/assets/23622319/619eef72-84d1-496c-9e0a-24962e5fa4d8

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 1 month ago

[frontend] [Fri May 17 06:53:00 UTC 2024] - Deployed 283679d0d30fc6121c0045430ca4d5315ac23377 to https://genshin-optimizer-prs.github.io/pr/2143/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri May 17 07:06:41 UTC 2024] - Deployed 0a57ee773d35ec4a54fce813ebce4ae2dc76309d to https://genshin-optimizer-prs.github.io/pr/2143/frontend (Takes 3-5 minutes after this completes to be available)

[Fri May 17 16:17:50 UTC 2024] - Deleted deployment