NumberInputLazy for artifact substat input

chengxi600 commented 1 month ago

Describe your changes

Replaced CustomNumberInput with NumberInputLazy

Issue or discord link

Resolves https://github.com/frzyc/genshin-optimizer/issues/2039

Testing/validation

https://github.com/frzyc/genshin-optimizer/assets/23622319/f671a1bc-bc72-4450-adfe-5752c66e9acd

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 1 month ago

[frontend] [Sat May 18 01:31:44 UTC 2024] - Deployed 6dea571626b0d4f64da422f538fe1f46e1d9f0f1 to https://genshin-optimizer-prs.github.io/pr/2146/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat May 18 06:32:06 UTC 2024] - Deployed 2813d0193135b57fe6bfd579c979e654359f2682 to https://genshin-optimizer-prs.github.io/pr/2146/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 19 06:16:11 UTC 2024] - Deployed 73d82dfddf907c5c99697c4e9eab2fa07afcb529 to https://genshin-optimizer-prs.github.io/pr/2146/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 19 22:25:11 UTC 2024] - Deployed 1a362a7648099770cd339cb99b72db12aa16bf01 to https://genshin-optimizer-prs.github.io/pr/2146/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 20 04:50:48 UTC 2024] - Deployed bff5b8097564c854799b7d98b1fb896ab2edcc0b to https://genshin-optimizer-prs.github.io/pr/2146/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 20 04:53:45 UTC 2024] - Deployed bff5b8097564c854799b7d98b1fb896ab2edcc0b to https://genshin-optimizer-prs.github.io/pr/2146/frontend (Takes 3-5 minutes after this completes to be available)

[Mon May 20 05:26:17 UTC 2024] - Deleted deployment

chengxi600 commented 1 month ago

I assumed this is caused by the 5vh in height for the parent wrapper I am not sure why you needed to set the height here manually?

without setting the height it looks like this for me: Screenshot 2024-05-18 at 12 09 30 PM

with 5vh: Screenshot 2024-05-18 at 12 10 02 PM

would it be better to just use fixed height or just not set any height?

frzyc commented 1 month ago

I think vh is fundamentally the wrong unit here, because its a relative unit to the viewheight, which can be different across different screensizes. The height of the element changes as the view height is changed(by using console)

Screenshot 2024-05-18 212326

If you want to fix the height of the element, you'd use em or just px (or figure out why the elements are so tall in the first place, which is likely due to a flex rule)

frzyc / genshin-optimizer