frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
750 stars 218 forks source link

Add -10 and -30 values to resin counter #2151

Closed josh-the-dev closed 1 month ago

josh-the-dev commented 1 month ago

Describe your changes

Added more options to the resin counter. Moved the buttons to a constant at the top to allow for more values later down the line easily.

Issue or discord link

Testing/validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

josh-the-dev commented 1 month ago

Will go through the checklist in a moment.

github-actions[bot] commented 1 month ago

[frontend] [Sun May 19 10:36:59 UTC 2024] - Deployed 7ba8be10bf12c4119bd46180f2e34096f979d5e3 to https://genshin-optimizer-prs.github.io/pr/2151/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 19 11:11:47 UTC 2024] - Deployed 393889fe5833d7125d9fa679569a42b0a480601a to https://genshin-optimizer-prs.github.io/pr/2151/frontend (Takes 3-5 minutes after this completes to be available)

[Sun May 19 16:52:44 UTC 2024] - Deleted deployment

[frontend] [Mon May 20 03:35:20 UTC 2024] - Deployed eebb7b789b3ea80acae089a4bc8fa6cd364c5a52 to https://genshin-optimizer-prs.github.io/pr/2151/frontend (Takes 3-5 minutes after this completes to be available)

[Mon May 20 04:01:14 UTC 2024] - Deleted deployment

josh-the-dev commented 1 month ago

I've added a new commit which should also address : #2150

Evidence here: image

josh-the-dev commented 1 month ago

Woops didn't mean to close 😅 . What are next steps to getting this merged? @frzyc you just handle that I assume ha!