Closed josh-the-dev closed 1 month ago
If you want to discuss, more than happy to do anything (e.g. adding a bit more gap between elements.) Let me know if you want any changes!
Just added a bit more gap, feel it looks a lot nicer with 0.5 gap on it.
[frontend] [Mon May 20 03:34:52 UTC 2024] - Deployed 01cc109085da7843d3c18c263aa569a67a6ab740 to https://genshin-optimizer-prs.github.io/pr/2152/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Mon May 20 08:43:06 UTC 2024] - Deployed 23802b4f21d4aecbc5085a865199f87b5ecd2362 to https://genshin-optimizer-prs.github.io/pr/2152/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Mon May 20 08:48:35 UTC 2024] - Deployed f2730402a9fa0ad000d17e2c8b77ec3f570321aa to https://genshin-optimizer-prs.github.io/pr/2152/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Mon May 20 08:53:19 UTC 2024] - Deployed ab86742682e8d348222893befbb00f88e04e8710 to https://genshin-optimizer-prs.github.io/pr/2152/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Mon May 20 10:10:26 UTC 2024] - Deployed cc0c1434af2de8676e077886fd207feca8e6c40e to https://genshin-optimizer-prs.github.io/pr/2152/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Mon May 20 19:58:24 UTC 2024] - Deployed d5de9a232886632992cb2f7538e0a4a076c05b45 to https://genshin-optimizer-prs.github.io/pr/2152/frontend (Takes 3-5 minutes after this completes to be available)
[Mon May 20 21:14:45 UTC 2024] - Deleted deployment
You are correct, left align looks better.
Describe your changes
Changing the quick link area to take more vertical space. Moving to links approach. Split links into 3 categories, as felt grouping was needed when we wanted to change this.
Issue or discord link
2140
Testing/validation
What used to be:![image](https://github.com/frzyc/genshin-optimizer/assets/25755821/92b111c0-3ede-4f3e-8119-b6afad8be530)
Now looks like:![image](https://github.com/frzyc/genshin-optimizer/assets/25755821/f3c28872-d955-4ab7-a63b-ae3339ec06e2)
Tested links according to what is in the .env file, and using prior environment variables so believe this should work.
More than happy to discuss the approach and if we want to change how this looks, however felt this fits in the overall brand of Genshin Optimizer.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.