convert artifact level button to textfield on theorycraft page

artloren commented 1 month ago

Describe your changes

Changed button artifact level input to TextField level input. Test PR to see if CI passes.

Issue or discord link

Resolves https://github.com/frzyc/genshin-optimizer/issues/2046

Testing/validation

Tested on frontend with negative values/invalid values (TextField rejects non-numerical characters), values larger than 20 (will revert to 20). Missing functionality: for 4 and 3 artifacts, the level cap does not change; this was not present in the original button-like input build, so it has not been changed (could be a separate issue).

w/ button-like input:

w/ textfield:

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 1 month ago

[frontend] [Mon May 20 03:32:11 UTC 2024] - Deployed dcb7b4bfa249b64b2af31434b26091bd6e591285 to https://genshin-optimizer-prs.github.io/pr/2153/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 20 04:56:31 UTC 2024] - Deployed 6aefd1e3b53c2e2fe736f7078da0552181d84dfe to https://genshin-optimizer-prs.github.io/pr/2153/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 20 05:52:43 UTC 2024] - Deployed 28f6a79a1066b1f821ccfa05ff34f619f4167468 to https://genshin-optimizer-prs.github.io/pr/2153/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 20 16:04:14 UTC 2024] - Deployed 3e3c19b9d8b27b0a9388a9dd0de235a64c23e7ee to https://genshin-optimizer-prs.github.io/pr/2153/frontend (Takes 3-5 minutes after this completes to be available)

[Mon May 20 21:13:26 UTC 2024] - Deleted deployment

artloren commented 1 month ago

Would you prefer to have the border outline? When I was testing the outline was difficult to see.

frzyc commented 1 month ago

LGTM, thanks for your contribution!

frzyc / genshin-optimizer