frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
750 stars 218 forks source link

Generated artifact header #2165

Closed Danzibob closed 1 month ago

Danzibob commented 1 month ago

Describe your changes

There are several possible cases for a single artifact in the modal window (depending on if you're comparing etc.), so I chose to just remove the title to avoid complexity. Also added english localization for this modal.

Note: I couldn't figure out how to trigger the TC Artifact case no matter what I compared to in my testing - I might not be familiar enough with the app or it might be a WIP feature, unsure.

My first contribution on this project so please correct me / explain stuff if needed!

Issue or discord link

Testing/validation

Example of an artifact that was already in the compared-to build:

no_title

Example of an artifact that was not in the compared-to build This behaviour is unchanged in this PR old_and_new

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

Are there any translations I need to do here? As far as I could tell the main UI isn't localized?

github-actions[bot] commented 1 month ago

[frontend] [Wed May 22 01:48:16 UTC 2024] - Deployed fcc32cd694936c5b1062532a133e84155b34b6fb to https://genshin-optimizer-prs.github.io/pr/2165/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jun 4 19:42:51 UTC 2024] - Deployed dc599b8cd888942dc80631d77c09ba3cfbbc8dbd to https://genshin-optimizer-prs.github.io/pr/2165/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jun 4 23:02:03 UTC 2024] - Deleted deployment