Open frzyc opened 1 month ago
[frontend] [Wed May 22 17:42:35 UTC 2024] - Deployed 4e4f9b15fb8ba5805f35bc487809528cf90b2705 to https://genshin-optimizer-prs.github.io/pr/2172/frontend (Takes 3-5 minutes after this completes to be available)
I know this is an experiment, but since this is a new change, can you verify contrast ratios between the orange/purple rarity background and the new roll colors? If we are going to redo colors, may as well make it WCAG compliant, or at least have a decent contrast ratio
Describe your changes
Issue or discord link
Testing/validation
Update the artifact roll colors:![image](https://github.com/frzyc/genshin-optimizer/assets/1754901/19b542c8-ec04-4971-943d-8748b3e9e6f9)
Before![image](https://github.com/frzyc/genshin-optimizer/assets/1754901/1006e077-8177-4559-95ee-4a83025f6a80)
After
Before![image](https://github.com/frzyc/genshin-optimizer/assets/1754901/68d58929-68a4-4478-8658-022a974d9f49)
After![image](https://github.com/frzyc/genshin-optimizer/assets/1754901/4d5a2ee7-bd80-4620-a400-721f0d526af1)
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.