frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
750 stars 218 forks source link

[experiment] minor UI glowup for artifact/weapon cards #2172

Open frzyc opened 1 month ago

frzyc commented 1 month ago

Describe your changes

Issue or discord link

Testing/validation

Update the artifact roll colors: image

Before image

After

image

Before image

After image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

github-actions[bot] commented 1 month ago

[frontend] [Wed May 22 17:42:35 UTC 2024] - Deployed 4e4f9b15fb8ba5805f35bc487809528cf90b2705 to https://genshin-optimizer-prs.github.io/pr/2172/frontend (Takes 3-5 minutes after this completes to be available)

nguyentvan7 commented 1 month ago

I know this is an experiment, but since this is a new change, can you verify contrast ratios between the orange/purple rarity background and the new roll colors? If we are going to redo colors, may as well make it WCAG compliant, or at least have a decent contrast ratio