Convert RelicEditor and LightConeEditor to modals - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

750 stars 218 forks source link

Convert RelicEditor and LightConeEditor to modals #2183

Closed tiffanynwyeung closed 1 month ago

tiffanynwyeung commented 1 month ago

Describe your changes

Wrap RelicEditor and LightConeEditor in modals
Create 'Add New' buttons on respective pages to bring up editors to add items

Issue or discord link

Testing/validation

relic page

lightcone page, adding a new lightcone and the subsequently created LC afterwards:

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[ ] I have commented my code in hard-to understand areas.
[ ] I have made corresponding changes to README or wiki.
[ ] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 1 month ago

[sr-frontend] [Fri May 31 07:01:23 UTC 2024] - Deployed 0d1c7382d2e8836580353e9298c8d1e2e4de0bbb to https://genshin-optimizer-prs.github.io/pr/2183/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri May 31 08:47:21 UTC 2024] - Deployed 88014622a0cbc38056390db6ca9952b095d1ab3f to https://genshin-optimizer-prs.github.io/pr/2183/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Fri May 31 21:26:40 UTC 2024] - Deleted deployment