Reset scrolling when going from Teams page to specific team - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

750 stars 218 forks source link

Reset scrolling when going from Teams page to specific team #2192

Closed Jerrry-10 closed 1 month ago

Jerrry-10 commented 1 month ago

Describe your changes

Adds useEffect to scroll to top of page, when /team/team_XXX is loaded on component mount.

Issue or discord link

Closes #2155

Testing/validation

scroll

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[ ] I have commented my code in hard-to understand areas.
[ ] I have made corresponding changes to README or wiki.
[ ] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 1 month ago

[frontend] [Sun Jun 2 21:57:12 UTC 2024] - Deployed ea4535258aba724a7b881f039f8f256ab7da7897 to https://genshin-optimizer-prs.github.io/pr/2192/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jun 4 19:38:49 UTC 2024] - Deleted deployment