Closed tiffanynwyeung closed 4 weeks ago
[sr-frontend] [Tue Jun 4 07:49:00 UTC 2024] - Deployed 9ea1f4dc74f2bacb3e126eda12c53733e7b197fd to https://genshin-optimizer-prs.github.io/pr/2198/sr-frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Tue Jun 4 08:02:16 UTC 2024] - Deployed 1a38daece30415e53a0bc2587cc3197418554e98 to https://genshin-optimizer-prs.github.io/pr/2198/sr-frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Tue Jun 4 08:14:29 UTC 2024] - Deployed e2a9b8c994fb0a8dfbd7b048afba8d74653878de to https://genshin-optimizer-prs.github.io/pr/2198/sr-frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Tue Jun 4 08:25:50 UTC 2024] - Deployed 6d2b220bcaa859ede3d24c472638a6c132f70d1d to https://genshin-optimizer-prs.github.io/pr/2198/sr-frontend (Takes 3-5 minutes after this completes to be available)
[Tue Jun 4 19:57:38 UTC 2024] - Deleted deployment
Describe your changes
soft list of things missing in SRO version compared to GO version:
allowEmpty
check on substats (unsure if it should be implemented here or when substat validation gets added)LocationAutocomplete
having more props/params passed to it as well as changed tosize="small"
because right now the larger size looks a bit awkward (should this get passed in manually instead as part of the extra props/params?)Issue or discord link
Resolves #2189
Testing/validation
relic inventory
clicking on edit relic
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.