Closed tiffanynwyeung closed 3 weeks ago
[sr-frontend] [Fri Jun 7 17:01:38 UTC 2024] - Deployed 6adac3d6b76399394fa3383847ec5f80717d5ea3 to https://genshin-optimizer-prs.github.io/pr/2218/sr-frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Fri Jun 7 17:08:20 UTC 2024] - Deployed a8914fcd936049b57729da4817be5f86ac34fb65 to https://genshin-optimizer-prs.github.io/pr/2218/sr-frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Fri Jun 7 17:23:38 UTC 2024] - Deployed 3edc80fd4df54a94de2147b306e6ed2926c717c7 to https://genshin-optimizer-prs.github.io/pr/2218/sr-frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Sat Jun 8 06:34:05 UTC 2024] - Deployed 7aef4f1fb8d4e3122c0212ef9f046249a102eb2d to https://genshin-optimizer-prs.github.io/pr/2218/sr-frontend (Takes 3-5 minutes after this completes to be available)
[Sun Jun 9 07:13:03 UTC 2024] - Deleted deployment
Describe your changes
allowEmpty
prop (this ended up not really being an issue but it doesn't really create errors without substat validation)RelicPlanarSlotKey
andRelicCavernSlotKey
were both callingtypeof allRelicSlotKeys
instead of their respective suballRelic[X]Keys
, which seemed out of place when compared with how theSetKeys
versions were initialized to the proper types.Issue or discord link
Testing/validation
Duplicate/Upgrade/Edit UI:
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.