frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
749 stars 218 forks source link

migrate nx to 19.2.2 #2220

Closed frzyc closed 3 weeks ago

frzyc commented 3 weeks ago

Describe your changes

Upgrade nx to 19.2.2:

NOTE: The configuration for @typescript-eslint/no-extra-semi and no-extra-semi that you were previously inheriting from the Nx eslint-plugin has been explicitly added to your .eslintrc.json file.

This is because those rules have been migrated to the https://eslint.style/ project (for stylistic only rules) and will no longer work in v8 of typescript-eslint. Having them explicitly in your config will make it easier for you to handle the transition, either by starting to use the ESLint Stylistic plugin, or removing the rules from your config. Ran update-19-1-0-rename-no-extra-semi from @nx/eslint-plugin Migrate no-extra-semi rules into user config, out of nx extendable configs

UPDATE .eslintrc.json

Ran 19-2-0-move-graph-cache-directory from nx Updates the default workspace data directory to .nx/workspace-data

UPDATE .gitignore UPDATE .prettierignore

NX Successfully finished running migrations from 'migrations.json'. This workspace is up to date!



## Issue or discord link

- <!--- link relevant issues to this PR, or provide a link to a discord message/thread -->

## Testing/validation

<!--- Add screenshots if possible -->

## Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

- [ ] I have commented my code in hard-to understand areas.
- [ ] I have made corresponding changes to README or wiki.
- [ ] For front-end changes, I have updated the corresponding English translations.
- [ ] I have run `yarn run mini-ci` locally to validate format and lint.
- [ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed
github-actions[bot] commented 3 weeks ago

[sr-frontend] [Sat Jun 8 22:16:14 UTC 2024] - Deployed 40835b764e0c56b40c54ec1b3383da6fa40cafa3 to https://genshin-optimizer-prs.github.io/pr/2220/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Jun 8 22:16:43 UTC 2024] - Deployed 40835b764e0c56b40c54ec1b3383da6fa40cafa3 to https://genshin-optimizer-prs.github.io/pr/2220/frontend (Takes 3-5 minutes after this completes to be available)

[Mon Jun 10 17:31:48 UTC 2024] - Deleted deployment