search

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
749 stars 218 forks source link

Duplicated `<strong>` in char_$char.json #2221

Closed LeafyLuigi closed 3 weeks ago

LeafyLuigi commented 3 weeks ago

Most, if not all char_$char.json files located in libs/gi/dm-localization/assets/locales/$lang/char_$char.json have a duplicated <strong> on their 10th lines (for "Normal Attack" subheadings) leading to slightly strange HTML generation with a nested <strong> on the teams > (team id) > ($char) > talents page.

 

Expected result:

HTML tree to contain something along the lines of 

<strong>Normal Attack</strong>

Actual result:

HTML tree contains

<strong><strong>Normal Attack</strong></strong>
HassnHamada commented 3 weeks ago

I can do this using find and replace. But I think it may be risky. Is there a better way to do it?

frzyc commented 3 weeks ago

find and replace likely won't work, since the next time we generate pipeline it will have to be done again. the "correct" way to fix this issue is to fix the datamine parsing pipeline: https://github.com/frzyc/genshin-optimizer/blob/master/libs/gi/dm-localization/src/executors/gen-locale/executor.ts