search

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
749 stars 218 forks source link

Add to roll correction #2222

Open frzyc opened 3 weeks ago

frzyc commented 3 weeks ago

https://discord.com/channels/785153694478893126/1249365040470036540 The 22.7% of this artifact for a 5 low roll is not rounded correctly, need to add to roll correction. image

HassnHamada commented 1 week ago

How should I approach this? I tried to have a look at it, but I didn't manage to understand how the rolls array is being computed/updated.

frzyc commented 1 week ago

@HassnHamada The roll tables are actually generated in another repo, but the issue is that we can't deterministically generate every rounded rolls. we have a separate "override" file that you can use to add to this, and this file is where you should make your change. https://github.com/frzyc/genshin-optimizer/blob/master/libs/gi/stats/Data/Artifacts/artifact_sub_rolls_correction.json