frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
749 stars 218 forks source link

Add an icon indication if a target has a description #2227

Closed clevernt closed 3 weeks ago

clevernt commented 3 weeks ago

Describe your changes

thought about adding a tooltip when hovering over the icon that shows truncated description but I'm not sure, would like some input on that

Issue or discord link

Testing/validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

nx-cloud[bot] commented 3 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 00394090c5a29c4880a2c0c2dc75897cf4fd6484. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run frontend:build:production`](https://cloud.nx.app/runs/JQ7MBSOWBt?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 3 weeks ago

[frontend] [Tue Jun 11 00:09:52 UTC 2024] - Deployed 2a94d873fbb460903279895d98c644e19967dbdc to https://genshin-optimizer-prs.github.io/pr/2227/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jun 11 11:52:25 UTC 2024] - Deployed fa72385f724f9de53c9b15529ca5d3585d80fba9 to https://genshin-optimizer-prs.github.io/pr/2227/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jun 11 18:25:40 UTC 2024] - Deleted deployment

frzyc commented 3 weeks ago

@clevernt I think this is a good idea, can you proceed with adding a hover tooltip here for the description as well?

clevernt commented 3 weeks ago

@frzyc I've added the tooltip image