frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

749 stars 218 forks source link

Fix opt empty #2230

Closed HassnHamada closed 3 weeks ago

HassnHamada commented 3 weeks ago

Describe your changes

Issue or discord link

discord

Testing/validation

https://github.com/frzyc/genshin-optimizer/assets/44922829/574a2fb7-f8e0-4c12-876d-52a363b45798

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[ ] I have commented my code in hard-to understand areas.
[ ] I have made corresponding changes to README or wiki.
[ ] For front-end changes, I have updated the corresponding English translations.
[ ] I have run yarn run mini-ci locally to validate format and lint.
[ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

nx-cloud[bot] commented 3 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e01165ca3c2cf21aa2b84cccf9f04296c162c0b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

- [`nx run frontend:build:production`](https://cloud.nx.app/runs/yLD4LrxkPF?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 3 weeks ago

[frontend] [Tue Jun 11 12:37:57 UTC 2024] - Deployed 6e67acd7fb0c2e874cb510da320b009ed7e089ff to https://genshin-optimizer-prs.github.io/pr/2230/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jun 11 16:55:03 UTC 2024] - Deployed 891755e6dfe7656b68731e5f8ce8f33e432b8981 to https://genshin-optimizer-prs.github.io/pr/2230/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jun 11 18:26:14 UTC 2024] - Deleted deployment