frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
749 stars 217 forks source link

[SRO] Add individual team page #2242

Closed tiffanynwyeung closed 2 weeks ago

tiffanynwyeung commented 2 weeks ago

Describe your changes

Notes:

  1. Not sure if character stuff works since we're generating empty teams, would have to add ability to add characters. Should this be added in this PR? Let me know.
  2. useTitle hook can be moved to libs/common so it can be used in SRO side, want me to make the port + GI changes in this PR as well?

Issue or discord link

Resolves #2191

Testing/validation

Teams page with initialized teams

image

Hover description + clickable area

image

Individual team page with header and character + settings tabs

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

nx-cloud[bot] commented 2 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 40ef1978fe94107ad1ec016aa5569d3136d38a0f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run sr-frontend:build:production`](https://cloud.nx.app/runs/QQhyHK5goT?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 2 weeks ago

[sr-frontend] [Sat Jun 15 18:45:35 UTC 2024] - Deployed dcf8969773b7e1e5af1c4d97bd9e37d58799900c to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Jun 15 18:46:39 UTC 2024] - Deployed dcf8969773b7e1e5af1c4d97bd9e37d58799900c to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Jun 15 18:48:27 UTC 2024] - Deployed b408f2be05485894c2bf71f891142459b992c1c6 to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Jun 15 18:49:28 UTC 2024] - Deployed b408f2be05485894c2bf71f891142459b992c1c6 to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Jun 15 18:53:22 UTC 2024] - Deployed 4973f49a85372e1058136274e88713e2ed5bfdd9 to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Jun 15 18:54:05 UTC 2024] - Deployed 4973f49a85372e1058136274e88713e2ed5bfdd9 to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Jun 15 19:01:37 UTC 2024] - Deployed 1d2bd5acc2a18523490f8e1f94ca66c85ec52514 to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Jun 15 19:01:55 UTC 2024] - Deployed 1d2bd5acc2a18523490f8e1f94ca66c85ec52514 to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)

[Sun Jun 16 04:40:09 UTC 2024] - Deleted deployment