Closed tiffanynwyeung closed 2 weeks ago
CI is running/has finished running commands for commit 40ef1978fe94107ad1ec016aa5569d3136d38a0f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
[sr-frontend] [Sat Jun 15 18:45:35 UTC 2024] - Deployed dcf8969773b7e1e5af1c4d97bd9e37d58799900c to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Sat Jun 15 18:46:39 UTC 2024] - Deployed dcf8969773b7e1e5af1c4d97bd9e37d58799900c to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Sat Jun 15 18:48:27 UTC 2024] - Deployed b408f2be05485894c2bf71f891142459b992c1c6 to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Sat Jun 15 18:49:28 UTC 2024] - Deployed b408f2be05485894c2bf71f891142459b992c1c6 to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Sat Jun 15 18:53:22 UTC 2024] - Deployed 4973f49a85372e1058136274e88713e2ed5bfdd9 to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Sat Jun 15 18:54:05 UTC 2024] - Deployed 4973f49a85372e1058136274e88713e2ed5bfdd9 to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)
[sr-frontend] [Sat Jun 15 19:01:37 UTC 2024] - Deployed 1d2bd5acc2a18523490f8e1f94ca66c85ec52514 to https://genshin-optimizer-prs.github.io/pr/2242/sr-frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Sat Jun 15 19:01:55 UTC 2024] - Deployed 1d2bd5acc2a18523490f8e1f94ca66c85ec52514 to https://genshin-optimizer-prs.github.io/pr/2242/frontend (Takes 3-5 minutes after this completes to be available)
[Sun Jun 16 04:40:09 UTC 2024] - Deleted deployment
Describe your changes
TeamCharacterSelector
componentTeamCard
andTeamInventory
Notes:
useTitle
hook can be moved tolibs/common
so it can be used in SRO side, want me to make the port + GI changes in this PR as well?Issue or discord link
Resolves #2191
Testing/validation
Teams page with initialized teams
Hover description + clickable area
Individual team page with header and character + settings tabs
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.