Closed HassnHamada closed 1 week ago
[frontend] [Sun Jun 16 12:22:49 UTC 2024] - Deployed 4bc820264ebd832e2db189154f34533c5970821d to https://genshin-optimizer-prs.github.io/pr/2244/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Sun Jun 16 17:35:05 UTC 2024] - Deployed 8021e375b7cb8d0130293c509e7e66869e9df1f6 to https://genshin-optimizer-prs.github.io/pr/2244/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Sun Jun 16 17:35:30 UTC 2024] - Deployed f363b72c5dd97a7632f88037f20cbabc96df5520 to https://genshin-optimizer-prs.github.io/pr/2244/frontend (Takes 3-5 minutes after this completes to be available)
[frontend] [Sun Jun 16 18:37:41 UTC 2024] - Deployed 8ce138c988b40180eee400b020bc1c0864363d17 to https://genshin-optimizer-prs.github.io/pr/2244/frontend (Takes 3-5 minutes after this completes to be available)
[Thu Jun 20 01:53:11 UTC 2024] - Deleted deployment
Describe your changes
Should I define
sortKey
somewhere here? Is there anything that should be refactored into separate files to be used in each tabartifacts
weapons
characters
?Issue or discord link
Resolve #1978
Testing/validation
https://github.com/frzyc/genshin-optimizer/assets/44922829/1721d6dc-9a0e-44bd-ba75-f38d7c551d3c
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.