Port useTitle hook to common lib - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

749 stars 217 forks source link

Port useTitle hook to common lib #2245

Closed tiffanynwyeung closed 2 weeks ago

tiffanynwyeung commented 2 weeks ago

Describe your changes

port useTitle hook from gi/ui to common/ui
add useTitle hook to sro/page-team (useTitle in SRO team page was originally supposed to be included in its related PR #2242, but needed useTitle to be ported to common/ui first)

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[ ] I have commented my code in hard-to understand areas.
[ ] I have made corresponding changes to README or wiki.
[ ] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 2 weeks ago

[sr-frontend] [Sun Jun 16 14:37:55 UTC 2024] - Deployed e62b75d23486a5f0205e04e4177245a908fffc89 to https://genshin-optimizer-prs.github.io/pr/2245/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Jun 16 14:38:25 UTC 2024] - Deployed e62b75d23486a5f0205e04e4177245a908fffc89 to https://genshin-optimizer-prs.github.io/pr/2245/frontend (Takes 3-5 minutes after this completes to be available)

[Sun Jun 16 15:17:56 UTC 2024] - Deleted deployment