frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
749 stars 217 forks source link

Fix mini-ci tests hanging and not checking for linter warnings #2246

Closed tiffanynwyeung closed 2 weeks ago

tiffanynwyeung commented 2 weeks ago

Describe your changes

Currently nx affected/run-many -t test is currently being set to watch for input due to some issues on Nx's side, making them hang (https://github.com/nrwl/nx/issues/26223); we can temporarily get around this by adding CI=true. Also split up targets into individual commands so we can pass max-warnings flag to catch lint warnings instead of them being skipped.

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

github-actions[bot] commented 2 weeks ago

[frontend] [Sun Jun 16 16:35:39 UTC 2024] - Deployed c9487584fdd1793ce794cb9c80c9047854dbf58e to https://genshin-optimizer-prs.github.io/pr/2246/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Jun 16 16:36:08 UTC 2024] - Deployed c9487584fdd1793ce794cb9c80c9047854dbf58e to https://genshin-optimizer-prs.github.io/pr/2246/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Sun Jun 16 19:13:17 UTC 2024] - Deleted deployment