Settings page - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

749 stars 217 forks source link

Settings page #2249

Closed priolette closed 2 weeks ago

priolette commented 2 weeks ago

Describe your changes

Moved the Database configuration to a separate Settings page, like in GO.

Issue or discord link

https://github.com/frzyc/genshin-optimizer/issues/1989

Testing/validation

Screenshot 2024-06-17 at 18 37 21

Screenshot 2024-06-17 at 18 38 32

Screenshot 2024-06-17 at 18 39 55

Known issues

Item counts in the header don't update when switching the Database
Not sure if the import information is correct after uploading a Database file

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[ ] I have commented my code in hard-to understand areas.
[ ] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions[bot] commented 2 weeks ago

[sr-frontend] [Mon Jun 17 15:44:07 UTC 2024] - Deployed f30f3df456fa264211d509d43c37978e8fa2b4db to https://genshin-optimizer-prs.github.io/pr/2249/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Jun 17 15:44:25 UTC 2024] - Deployed f30f3df456fa264211d509d43c37978e8fa2b4db to https://genshin-optimizer-prs.github.io/pr/2249/frontend (Takes 3-5 minutes after this completes to be available)

[Mon Jun 17 18:41:20 UTC 2024] - Deleted deployment