Update buffing and conditional systems - Githubissues

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

749 stars 217 forks source link

Update buffing and conditional systems #2253

Closed lantua closed 6 days ago

lantua commented 1 week ago

Describe your changes

This PR updates the buffing and conditional systems in gi-formula and sr-formula. In particular,

All conditionals are now only applied in buffing context
All conditionals are fixed to used only sum accumulator
Conditional values must include both the source and destination of the buff
Remove activeBuff and add notSelfBuff

Additionally, there are other calculator changes

Improve calculator debugging APIs
Simplify non-stacking entry API

Issue or discord link

https://discord.com/channels/785153694478893126/1250529172183453747

Testing/validation

Unit test is updated

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[X] I have commented my code in hard-to understand areas.
[X] I have made corresponding changes to README or wiki.
[X] For front-end changes, I have updated the corresponding English translations.
[X] I have run yarn run mini-ci locally to validate format and lint.
[X] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed