Bold the selected header tab text

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.

https://frzyc.github.io/genshin-optimizer/

MIT License

749 stars 217 forks source link

Bold the selected header tab text #2263

Open frzyc opened 1 week ago

frzyc commented 1 week ago

          I think the text is supposed to be bolded as well

design doc:

site:

_Originally posted by @nguyentvan7 in https://github.com/frzyc/genshin-optimizer/pull/2261#discussion_r1650201695_

Please read the original discussion. The solution may seem straight forward but execution can be a tad tricky.

Need to bold selected header tab
Figure out a way so that when swapping between bolded and unbolded text within the header tabs, there is no layout shift, due to the text being slightly different size switching between bolded and unbolded.

claireoe commented 1 week ago

@frzyc can I assist with this issue?

claireoe commented 6 days ago

@frzyc just want to confirm the task is for the headers on the '/archive' page ? The header values are already in bold. Should i just make the font colour match the underline indicator 'blue'?

frzyc commented 6 days ago

@frzyc just want to confirm the task is for the headers on the '/archive' page ? The header values are already in bold. Should i just make the font colour match the underline indicator 'blue'?

I dont think "archive" is mentioned in this issue anywhere. this issue is referring to the site header, like the main site navigation on the top.

claireoe commented 5 days ago

Okay, I couldn't see the text on the heading

but can see it on a larger screen.

claireoe commented 5 days ago

@frzyc created a pull request https://github.com/frzyc/genshin-optimizer/pull/2277

claireoe commented 4 days ago

@frzyc created a pull request with the requirements fulfilled https://github.com/frzyc/genshin-optimizer/pull/2279